Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Limit the length of app password names #31680

Merged
merged 3 commits into from
May 14, 2022
Merged

[stable21] Limit the length of app password names #31680

merged 3 commits into from
May 14, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 23, 2022 •
edited by nickvergessen
Loading

backport of #31658 and #31688

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 21.0.10 milestone Mar 23, 2022
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Mar 23, 2022
@nickvergessen nickvergessen force-pushed the backport/31658/stable21 branch from 90d7251 to 3b1bde9 Compare March 23, 2022 20:50
@nickvergessen nickvergessen mentioned this pull request Mar 23, 2022
Merged
@blizzz blizzz removed this from the Nextcloud 21.0.10 milestone Apr 21, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Apr 21, 2022 •
edited
Loading

The autoloaders are not up to date
…
And commit the result

@nickvergessen
Copy link
Member

Seems unrelated thou

@nickvergessen nickvergessen added this to the Nextcloud 21.0.10 milestone Apr 21, 2022
@nickvergessen
Copy link
Member

If this is merged, #32305 needs backporting too so installing with Chrome based browsers with long user agents still works

@skjnldsv
Copy link
Member

to merge or not to merge?

@skjnldsv
Copy link
Member

/rebase

@nickvergessen @skjnldsv
Limit the length of app password names
efbbdb7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @skjnldsv
Fix unit tests
924eb1e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nextcloud-command nextcloud-command force-pushed the backport/31658/stable21 branch from 3b1bde9 to 924eb1e Compare May 13, 2022 18:34
@nickvergessen
Copy link
Member

My vote is for yes

@skjnldsv
Autoloader update
84b0504 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 14, 2022
@skjnldsv skjnldsv merged commit 6f9a3a4 into stable21 May 14, 2022
@skjnldsv skjnldsv deleted the backport/31658/stable21 branch May 14, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@miaulalala miaulalala Awaiting requested review from miaulalala

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: authentication
Projects
None yet
Milestone
Nextcloud 21.0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @skjnldsv @blizzz