Clarify that some interface are not meant to be implemented #31447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
approved these changes
Mar 4, 2022
|
here are two examples where the interface needed extending: |
ChristophWurst
approved these changes
Mar 4, 2022
1905d2b to
58410b7
Compare
juliusknorr
approved these changes
Mar 4, 2022
|
nice! please make phpcs happy |
This make sure that apps don't implement this interfaces and gives us more liberty to add new methods to them (as long as it is compatible from an usage point of view) Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-authored-by: Vincent Petry <vincent@nextcloud.com>
96259ee to
e495c57
Compare
MichaIng
reviewed
Mar 5, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
e495c57 to
5a17415
Compare
MichaIng
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make sure that apps don't implement these interfaces and give us
more liberty to add new methods to them (as long as it is compatible
from a usage point of view). This just documents something we were already
doing before.
Signed-off-by: Carl Schwan carl@carlschwan.eu