Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be conservative when reading from fresh created column #31436

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 3, 2022

When a column was added into a table definition we may run into risk that when it is read it may happen on a DB node where the column is not synced to, yet. Then the where clause is also not necessary since all rows qualify.

@blizzz blizzz added this to the Nextcloud 24 milestone Mar 3, 2022
@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 3, 2022
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/migration-column-handling branch from e6a67c1 to f3668f2 Compare March 3, 2022 20:26
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense, but please fix the indents and make them consistent

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Mar 3, 2022

+1 makes sense, but please fix the indents and make them consistent

the odd indents turned out to be a Microsoft Github presentation bug

@PVince81 PVince81 merged commit 8a52591 into master Mar 4, 2022
@PVince81 PVince81 deleted the fix/noid/migration-column-handling branch March 4, 2022 09:20
@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

/backport to stable23

@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

/backport to stable22

@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

@blizzz @come-nc needs backport further down I guess, to match the UUID migration fixes ?

@blizzz
Copy link
Member Author

blizzz commented Mar 10, 2022

/backport to stable21

@blizzz
Copy link
Member Author

blizzz commented Mar 10, 2022

/backport to stable20

@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable20 failed. Please do this backport manually.

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress backport-request labels Mar 21, 2022
@blizzz
Copy link
Member Author

blizzz commented Mar 21, 2022

backports to 21 and 20 done manually ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants