Fix files node API failed rename/copy #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Petry <pvince81@owncloud.com>
MorrisJobke
requested changes
Jan 11, 2017
| @@ -1,7 +1,5 @@ | |||
| <?php | |||
| /** | |||
| * @copyright Copyright (c) 2016, ownCloud, Inc. | |||
| * | |||
There was a problem hiding this comment.
Misread the conflict resolution dialog when cherry picking, thought this was introduces in an older post-fork upstream commit
fixed now
| @@ -1,7 +1,5 @@ | |||
| <?php | |||
| /** | |||
| * @copyright Copyright (c) 2016, ownCloud, Inc. | |||
| * | |||
added 2 commits
January 12, 2017 13:52
Whenever a rename or copy operation failed on the view, we must throw an exception instead of just ignoring. Signed-off-by: Vincent Petry <pvince81@owncloud.com>
Signed-off-by: Vincent Petry <pvince81@owncloud.com>
91a78f7 to
269b652
Compare
rullzer
approved these changes
Jan 12, 2017
MorrisJobke
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of owncloud/core#26629