Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Avoid calling image* methods on boolean #30116

Merged
merged 3 commits into from
Dec 13, 2021
Merged

[stable22] Avoid calling image* methods on boolean #30116

merged 3 commits into from
Dec 13, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #30040

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.4 milestone Dec 6, 2021
@come-nc come-nc force-pushed the backport/30040/stable22 branch from d897520 to df639f7 Compare December 7, 2021 14:58
@nickvergessen nickvergessen added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 7, 2021
@come-nc come-nc force-pushed the backport/30040/stable22 branch from df639f7 to 623d3c7 Compare December 9, 2021 14:57
@come-nc
Avoid calling image* methods on boolean
df7de41 
This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix typing problems in OC_Image
4c3f983 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Avoid assignment in if clause
df23d75 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/30040/stable22 branch from 623d3c7 to df23d75 Compare December 13, 2021 08:35
@come-nc come-nc merged commit db8ed04 into stable22 Dec 13, 2021
@come-nc come-nc deleted the backport/30040/stable22 branch December 13, 2021 09:40
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
Merged
9 tasks
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solracsf solracsf solracsf approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 22.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@solracsf @CarlSchwan @come-nc @nickvergessen