Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast orphan subscription id to int #30001

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Cast orphan subscription id to int #30001

merged 1 commit into from
Dec 1, 2021

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 1, 2021 •
edited
Loading

Fixes https://help.nextcloud.com/t/nextcloud-23-upgrade-problem-dav-app/128275/7

DB columns are of type int by default, so they need to be casted. Otherwise the invocation of \OCA\DAV\Migration\RemoveDeletedUsersCalendarSubscriptions::deleteOrphanSubscription causes a type error.

Ref #28716

@ChristophWurst
Cast orphan subscription id to int
478953d 
DB columns are of type int by default, so they need to be casted.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 24 milestone Dec 1, 2021
@ChristophWurst ChristophWurst requested review from st3iny, tcitworld, miaulalala and a team December 1, 2021 09:49
@ChristophWurst ChristophWurst self-assigned this Dec 1, 2021
@ChristophWurst ChristophWurst requested review from nickvergessen, skjnldsv and CarlSchwan and removed request for a team December 1, 2021 09:49
@ChristophWurst
Copy link
Member Author

/backport to stable23

@ChristophWurst
Copy link
Member Author

@tcitworld was this not backported? #28716 (comment)

st3iny
st3iny approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tcitworld
Copy link
Member

@tcitworld was this not backported? #28716 (comment)

Apparently not 🤷

@ChristophWurst
Copy link
Member Author

Apparently not shrug

The bot doesn't want to backport your PR apparently 😢

@ChristophWurst ChristophWurst merged commit 3a1ef2b into master Dec 1, 2021
@ChristophWurst ChristophWurst deleted the fix/subscription-id-int branch December 1, 2021 13:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 1, 2021
Merged
@solracsf solracsf mentioned this pull request Dec 20, 2021
Closed
@b90g
Copy link

b90g commented Dec 20, 2021

I just downloaded it with updater.phar and tried to execute occ upgrade... when are you going to release the fixed version?

@ChristophWurst
Copy link
Member Author

https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

@b90g
Copy link

b90g commented Jan 6, 2022 •
edited
Loading

https://github.com/nextcloud/server/releases - sorry for nagging. but considering that 22.2.0-22.2.3 happend within 6 days, i hope this release will happen soon. :( but i guess i have to patch manually.

https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule/_compare/a371bf115315f152e0f253003e696e55ea50caf4...2764b7abd0ddfcef80849321a926a84c51a9835a

ok they changed it. i'll wait thenks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: dav
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @tcitworld @b90g @st3iny @miaulalala @skjnldsv