Fix missing setlocale with php 8

[YoitoFes]

When php version = 8, basename('§') returns '§' even if LC_ALL is non-UTF-8 locale.
Since OC_Util::isSetLocaleWorking() assumes basename('§') returns empty string with non-UTF-8 locale,
the function with php 8 incorrectly skips setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

This issue found in #29296 and The PR may be able to resolve it.

[PVince81]

👍

[PVince81]

/backport to stable23

[solracsf]

What if escapeshellcmd() is a disabled function in php? 🤔

[PVince81]

What if escapeshellcmd() is a disabled function in php? thinking

not sure if it's as common as disabling the exec and shell_exec

but you're right to be careful, is there a way to detect disabled functions ?
if disabled then we could fall back to basename

[solracsf]

@PVince81 https://www.php.net/manual/en/function.function-exists.php

if (!function_exists('escapeshellcmd')) {
...
}

[YoitoFes]

Is escapeshellarg disabled less often than escapeshellcmd? escapeshellarg is used in Nextcloud's source code while escapeshellcmd is not.

[solracsf]

Hard to say, but it is always a good practice check if the function exists before call it, and have a fallback 😉

[YoitoFes]

I think basename can not be used as a fallback since the function with php8 causes the issue.
So I added escapeshellarg and preg_match as fallbacks.

[PVince81]

Fine by me 👍

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[PVince81]

seems the bot is lagging, no further backports yet?

[PVince81]

/backport to stable22

[PVince81]

/backport to stable21