Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an OCP for trusted domain helper #29444

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Add an OCP for trusted domain helper #29444

merged 1 commit into from
Oct 28, 2021

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Oct 26, 2021
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 26, 2021
@nickvergessen nickvergessen force-pushed the bugfix/noid/public-api-for-trusted-domain-helpers branch from 7e8e6d3 to 65ef956 Compare October 26, 2021 11:33
@juliusknorr
Copy link
Member

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh

ChristophWurst
ChristophWurst requested changes Oct 26, 2021
View reviewed changes
lib/public/Security/ITrustedDomainHelper.php Outdated Show resolved Hide resolved
lib/public/Security/ITrustedDomainHelper.php Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Oct 26, 2021
@nickvergessen nickvergessen force-pushed the bugfix/noid/public-api-for-trusted-domain-helpers branch from 65ef956 to 1eafdd0 Compare October 27, 2021 12:25
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Oct 27, 2021
ChristophWurst
ChristophWurst approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks, fine otherwise :)

lib/public/Security/ITrustedDomainHelper.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the bugfix/noid/public-api-for-trusted-domain-helpers branch from 1eafdd0 to d17966d Compare October 27, 2021 12:53
@ChristophWurst ChristophWurst mentioned this pull request Oct 27, 2021
Closed
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2021
@nickvergessen nickvergessen mentioned this pull request Oct 27, 2021
Closed
1 task
@juliusknorr
Copy link
Member

Tests need some adjustment as well ;)

@nickvergessen
Add an OCP for trusted domain helper
c42f5bc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/public-api-for-trusted-domain-helpers branch from d17966d to c42f5bc Compare October 28, 2021 08:24
@nickvergessen nickvergessen merged commit 74cfe73 into master Oct 28, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/public-api-for-trusted-domain-helpers branch October 28, 2021 09:45
@nickvergessen nickvergessen mentioned this pull request Oct 28, 2021
Merged
2 tasks
@nickvergessen nickvergessen mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @juliusknorr @LukasReschke @ChristophWurst