Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calendar schedule options translatable #29375

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Make calendar schedule options translatable #29375

merged 1 commit into from
Oct 22, 2021

Conversation

juliusknorr
Copy link
Member

  • Rename the guests input to "Number of guests" to be more descriptive
  • Make placeholder of inputs translatable

@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Oct 22, 2021
@juliusknorr juliusknorr requested review from ChristophWurst, GretaD, a team, artonge, Pytal and szaimen and removed request for a team October 22, 2021 07:27
@juliusknorr
Make calendar schedule options translatable
b30f499 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/translate-calendar-schedule-response branch from cee471e to b30f499 Compare October 22, 2021 07:33
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2021
@szaimen
Copy link
Contributor

szaimen commented Oct 22, 2021

Failing test is unrelated

@szaimen szaimen merged commit 686f293 into master Oct 22, 2021
@szaimen szaimen deleted the bugfix/noid/translate-calendar-schedule-response branch October 22, 2021 08:41
@st3iny
Copy link
Member

st3iny commented Oct 22, 2021

/backport to stable22

@st3iny
Copy link
Member

st3iny commented Oct 22, 2021

/backport to stable21

@st3iny
Copy link
Member

st3iny commented Oct 22, 2021

/backport to stable20

This was referenced Oct 22, 2021
Merged
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav feature: language l10n and translations
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
5 participants
@juliusknorr @szaimen @st3iny @nickvergessen @ChristophWurst