Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresponsive click on avatar in Profile Preview Card #29345

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Fix unresponsive click on avatar in Profile Preview Card #29345

merged 1 commit into from
Oct 21, 2021

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 20, 2021 •
edited
Loading

Remove unused click handler on the Avatar component to fix the unresponsive click, plus minor styling updates and cleanup :)

@Pytal Pytal added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Oct 20, 2021
@Pytal Pytal added this to the Nextcloud 23 milestone Oct 20, 2021
@Pytal Pytal requested a review from a team October 20, 2021 16:33
@Pytal Pytal self-assigned this Oct 20, 2021
@Pytal Pytal requested review from PVince81, artonge and szaimen and removed request for a team October 20, 2021 16:33
@Pytal
Copy link
Member Author

Pytal commented Oct 20, 2021

/compile amend /

@PVince81
Copy link
Member

/compile amend /

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 21, 2021
@artonge
Copy link
Contributor

artonge commented Oct 21, 2021

/rebase

@artonge
Copy link
Contributor

artonge commented Oct 21, 2021 •
edited
Loading

Do we have a list of available commands? I never know if it is @something-bot/rebase or /rebase or something else

@Pytal
Copy link
Member Author

Pytal commented Oct 21, 2021

Do we have a list of available commands? I never know if it is @something-bot/rebase or /rebase or something else

I believe we just have the command-* prefixed workflows https://github.com/nextcloud/server/tree/master/.github/workflows, and dependabot commands are under a toggle :)

@skjnldsv skjnldsv force-pushed the fix/profile-preview-card branch from 662a7ed to 654813f Compare October 21, 2021 15:40
@skjnldsv
Copy link
Member

Rebased and ready to go

@Pytal Pytal force-pushed the fix/profile-preview-card branch from 654813f to e9a3976 Compare October 21, 2021 20:45
@Pytal
Copy link
Member Author

Pytal commented Oct 21, 2021

/compile amend /

@Pytal @nextcloud-command
Remove unused click handler
06c9a8d 
- Handle long lines unbroken by white space
- Cleanup

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit 8a511de into master Oct 21, 2021
@Pytal Pytal deleted the fix/profile-preview-card branch October 21, 2021 22:18
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @PVince81 @artonge @skjnldsv