Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PHP7.3 for Nextcloud 23 #29285

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Deprecate PHP7.3 for Nextcloud 23 #29285

merged 1 commit into from
Oct 18, 2021

Conversation

ChristophWurst
Copy link
Member

  • 7.3 reaches EOL shortly after the release of 23.0.0
  • Nextcloud 24 will require PHP7.4

Ref #29258

@ChristophWurst
Deprecate PHP7.3 for Nextcloud 23
4b8f8c5 
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Oct 18, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Oct 18, 2021
@ChristophWurst ChristophWurst requested review from solracsf and a team October 18, 2021 07:17
@ChristophWurst ChristophWurst self-assigned this Oct 18, 2021
@ChristophWurst ChristophWurst requested review from ArtificialOwl, CarlSchwan and come-nc and removed request for a team October 18, 2021 07:17
@solracsf
Copy link
Member

LGTM (https://github.com/nextcloud/server/blob/master/lib/versioncheck.php should be updated later)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 18, 2021
@ChristophWurst
Copy link
Member Author

LGTM (https://github.com/nextcloud/server/blob/master/lib/versioncheck.php should be updated later)

#29286 :)

@ChristophWurst ChristophWurst mentioned this pull request Oct 18, 2021
Closed
@ChristophWurst ChristophWurst merged commit 643e85c into master Oct 18, 2021
@ChristophWurst ChristophWurst deleted the fix/php-7.3-deprecation branch October 18, 2021 08:00
@sunjam sunjam mentioned this pull request Oct 18, 2021
Closed
@sunjam sunjam mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@solracsf solracsf solracsf approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @solracsf @juliusknorr @skjnldsv