-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide contactsmenu as ocs #29249
Provide contactsmenu as ocs #29249
Conversation
I tested it against my local nc:
|
Oh, so I didn't know, but the contactmanager basically works on the (system)addressbook. Doesn't look fixable in short term. So either we just do it this way or we have to delay the PR I fear |
server/lib/private/Contacts/ContactsMenu/ContactsStore.php Lines 286 to 290 in 215aef3
We can fix that easily by making sure we set the id that is not set anymore
Two options:
|
For profile we do not need the avatar, I think. As this is only used when we show a sharee, so the user Avatar is already present. |
5fde757
to
33128e6
Compare
ID is fixed @tobiasKaminsky |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
33128e6
to
660090d
Compare
I would instead go with #29269 |
Ref #28751
Ref nextcloud/files-clients#1