Send the subscription key to the appstore requests #29235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested changes
Oct 14, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a435fc3 to
b554234
Compare
b554234 to
c91b238
Compare
nickvergessen
approved these changes
Oct 14, 2021
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
c91b238 to
1f76423
Compare
kesselb
reviewed
Oct 14, 2021
| @@ -44,7 +44,7 @@ class AppFetcher extends Fetcher { | |||
| private $compareVersion; | |||
|
|
|||
| /** @var IRegistry */ | |||
| private $registry; | |||
| protected $registry; | |||
There was a problem hiding this comment.
Suggested change
| protected $registry; |
I think this can go.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #28569