Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test similar folder names + S3 tests with minio #29212

Closed
wants to merge 2 commits into from

Conversation

PVince81
Copy link
Member

To verify that S3 folder handling is working fine.

For #25370

@PVince81
Copy link
Member Author

it won't trigger on S3 because S3 as external storage is not running in CI :-/

@PVince81
Copy link
Member Author

see #29216 for enabling the tests

To verify that S3 folder handling is working fine.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the techdebt/noid/test-similar-names branch from 010c70a to 4cedfe8 Compare October 13, 2021 18:31
@PVince81 PVince81 changed the title Test similar folder names Test similar folder names + S3 tests with minio Oct 13, 2021
@PVince81
Copy link
Member Author

I've pushed a test env for Minio with Docker, but it currently all tests fail locally with this:

TypeError: Argument 2 passed to Aws\AwsClient::getCommand() must be of the type array, string given, called in /srv/www/htdocs/server/3rdparty/aws/aws-sdk-php/src/AwsClientTrait.php on line 86

Run with: ./autotest-external.sh sqlite amazons3-minio

Also, as far as I understand this is not suitable for Drone as we probably can't run Docker in there, so this will likely require yet another env file that connects to a separate minio image as prepared by Drone.
I don't have enough knowledge to setup the latter so will need help.

In any case, first need to make those tests pass locally...

@PVince81
Copy link
Member Author

obsoleted by #29220

@PVince81 PVince81 closed this Oct 18, 2021
@PVince81 PVince81 deleted the techdebt/noid/test-similar-names branch October 18, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant