Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve versions in S3 copy #29179

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Oct 12, 2021

Issues:

  • mtime not preserved, might need a separate mtime field of sorts for versions: https://stackoverflow.com/a/13981403
  • cannot download the preserved versions for some reason
  • concern about the order of copy, should we copy the versions first in the right order and then the final file ? there seems to be no way to specify a "target version" of sorts
  • need to test with copying folders, should work though

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added the 2. developing Work in progress label Oct 12, 2021
@PVince81 PVince81 self-assigned this Oct 12, 2021
@PVince81 PVince81 marked this pull request as draft October 12, 2021 09:47
@PVince81
Copy link
Member Author

PVince81 commented Nov 2, 2021

abandoned in favor of making the server aware of versioned buckets: #29220

@PVince81 PVince81 closed this Nov 2, 2021
@skjnldsv skjnldsv deleted the enh/noid/s3-preserve-versions-on-copy branch March 14, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant