Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMC-464 Highlight the search term on no results #28682

Merged
merged 1 commit into from
Sep 1, 2021
Merged

NMC-464 Highlight the search term on no results #28682

merged 1 commit into from
Sep 1, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 1, 2021 •
edited
Loading

Supersede #28644

image

@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Sep 1, 2021
@skjnldsv skjnldsv requested a review from a team September 1, 2021 07:26
@skjnldsv skjnldsv self-assigned this Sep 1, 2021
@skjnldsv skjnldsv requested review from PVince81, Pytal and szaimen and removed request for a team September 1, 2021 07:26
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2021

/backport to stable22

@skjnldsv skjnldsv mentioned this pull request Sep 1, 2021
Closed
@skjnldsv skjnldsv changed the title Search function strong tag for user input NMC-464 Highlight the search term on no results #28644 Sep 1, 2021
@skjnldsv skjnldsv changed the title NMC-464 Highlight the search term on no results #28644 NMC-464 Highlight the search term on no results Sep 1, 2021
szaimen
szaimen approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen

This comment has been minimized.

Sign in to view
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 1, 2021

/compile amend /

@TSI-kavitasonawane @nextcloud-command
Search function strong tag for user input
d2aed25 
Signed-off-by: Kavita Sonawane <kavita.sonawane@t-systems.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen merged commit 1a4e4b8 into master Sep 1, 2021
@szaimen szaimen deleted the NMC-464 branch September 1, 2021 11:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 1, 2021
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 2, 2021

/backport to stable22

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 2, 2021

/backport to stable22

Ah, already backported! Thanks!

@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@Pytal Pytal Awaiting requested review from Pytal

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement high
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @szaimen @CarlSchwan @TSI-kavitasonawane