Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update packages in build/package-lock.json when running js-tests #28528

Conversation

nickvergessen
Copy link
Member

I find it quite distrubing to always end up with a modified build/package-lock.json file after running autotest-js.sh
Updating should be done explicitly (or automatically with dependabot) and then be commited like that to the repo, not running locally when you run tests

@juliusknorr
Copy link
Member

Makes sense though we should also commit that properly then in the first run https://github.com/nextcloud/server/blob/master/build/package-lock.json and remove it from .gitignore

@nickvergessen nickvergessen requested a review from Pytal September 13, 2021 07:44
@nickvergessen nickvergessen force-pushed the techdebt/noid/dont-update-packages-on-test-execution branch from 49811ae to dde32d7 Compare September 13, 2021 07:44
@nickvergessen
Copy link
Member Author

Makes sense though we should also commit that properly then in the first run https://github.com/nextcloud/server/blob/master/build/package-lock.json and remove it from .gitignore

Done, please review

@nickvergessen
Copy link
Member Author

Are failing JS tests related? Works locally

@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/dont-update-packages-on-test-execution branch from dde32d7 to 238f29e Compare October 13, 2021 11:36
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsunit fails ?

@nickvergessen
Copy link
Member Author

As mentioned above, I have no idea.

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 19, 2021
@nickvergessen
Copy link
Member Author

So anyone from @nextcloud/server-frontend wants to pick this up? Otherwise I would close it any we still have the updates happening

@artonge
Copy link
Contributor

artonge commented Jan 14, 2022

So anyone from @nextcloud/server-frontend wants to pick this up? Otherwise I would close it any we still have the updates happening

Should be good as of: #30567

@artonge artonge closed this Jan 14, 2022
@artonge
Copy link
Contributor

artonge commented Jan 14, 2022

The .gitignore part would be nice to have though

@skjnldsv skjnldsv deleted the techdebt/noid/dont-update-packages-on-test-execution branch March 14, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants