-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update packages in build/package-lock.json when running js-tests #28528
Don't update packages in build/package-lock.json when running js-tests #28528
Conversation
Makes sense though we should also commit that properly then in the first run https://github.com/nextcloud/server/blob/master/build/package-lock.json and remove it from .gitignore |
49811ae
to
dde32d7
Compare
Done, please review |
Are failing JS tests related? Works locally |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
dde32d7
to
238f29e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsunit fails ?
As mentioned above, I have no idea. |
So anyone from @nextcloud/server-frontend wants to pick this up? Otherwise I would close it any we still have the updates happening |
Should be good as of: #30567 |
The .gitignore part would be nice to have though |
I find it quite distrubing to always end up with a modified
build/package-lock.json
file after running autotest-js.shUpdating should be done explicitly (or automatically with dependabot) and then be commited like that to the repo, not running locally when you run tests