Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle case where storage can't be created in getStorageRootId #27540

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

icewind1991
Copy link
Member

Prevents a hard error when the storage can't be created

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jun 17, 2021
@icewind1991 icewind1991 added this to the Nextcloud 22 milestone Jun 17, 2021
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems to make sense, not sure about other side effects though

@juliusknorr juliusknorr merged commit bdb1525 into master Jun 18, 2021
@juliusknorr juliusknorr deleted the getstoragerootid-failed-storage branch June 18, 2021 12:17
@juliusknorr
Copy link
Member

juliusknorr commented Jun 18, 2021

@icewind1991 backports?

@blizzz blizzz mentioned this pull request Jun 23, 2021
39 tasks
@icewind1991
Copy link
Member Author

/backport to stable21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants