Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation phpunit test #27352

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix translation phpunit test #27352

merged 1 commit into from
Jun 2, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 2, 2021 •
edited
Loading

Regression from #27063

@skjnldsv
Fix translation phpunit test
b228e8a 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@LukasReschke
Copy link
Member

LukasReschke commented Jun 2, 2021 •
edited
Loading

:-/ - This means another rebase round.

Why do we merge things in which CI fails? Is it because CI is too often failing? (in which case we should rather remove flaky tests IMHO)

@LukasReschke LukasReschke merged commit 2637f92 into master Jun 2, 2021
@LukasReschke LukasReschke deleted the fix/l10n-test branch June 2, 2021 17:16
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2021

Why do we merge things in which CI fails?

That's called a mistake and we're currently merging pending PRs for release

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2021

:-/ - This means another rebase round.

Welcome to my life

@LukasReschke
Copy link
Member

LukasReschke commented Jun 2, 2021 •
edited
Loading

That's called a mistake and we're currently merging pending PRs for release

Not blaming you, @skjnldsv. More trying to find solutions as I saw CI red on master several times this week. :-)

Would more hardware help here to process the tests for all PRs faster?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2021

Would more hardware help here to process the tests for all PRs faster?

Maybe :)
Drone is capricious 🙈

Moving al lthe phpunit to github action would help make it faster already I think 😉

@LukasReschke LukasReschke mentioned this pull request Jun 2, 2021
Closed
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valdnet Valdnet Valdnet approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@Pytal Pytal Awaiting requested review from Pytal

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: language l10n and translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @LukasReschke @Valdnet