-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite requesttoken.spec.js with Jest #27286
Rewrite requesttoken.spec.js with Jest #27286
Conversation
48e262b
to
4c25ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!! ❤️
Can't thank you enough! It was really becoming complicated with webpack5 and stuff!! 🚀 |
[Jest](https://jestjs.io/) is a test runner that focuses on simplicity. It instruments babel to transform modules and test them. Using Jest simplifies the existing configuration and allows dropping a bunch of workarounds, as well as following the shared Babel configuration for new code. Signed-off-by: François Freitag <mail@franek.fr>
4c25ea9
to
b0847ab
Compare
Thanks for the review! I just downgraded the jest-babel and jest version to
Also, it avoids using |
Jest is a test runner that focuses on simplicity.
It instruments babel to transform modules and test them.
Using Jest simplifies the existing configuration and allows dropping a
bunch of workarounds, as well as following the shared Babel
configuration for new code.
Signed-off-by: François Freitag mail@franek.fr
Closes #27229
Closes #27227