Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GHCR PHP 7.3 Acceptance Container #27214

Merged
merged 2 commits into from
May 28, 2021
Merged

Use GHCR PHP 7.3 Acceptance Container #27214

merged 2 commits into from
May 28, 2021

Conversation

LukasReschke
Copy link
Member

No description provided.

@LukasReschke LukasReschke added the 3. to review Waiting for reviews label May 28, 2021
@LukasReschke LukasReschke requested a review from MorrisJobke May 28, 2021 12:12
@MorrisJobke MorrisJobke added this to the Nextcloud 22 milestone May 28, 2021
@gary-kim
Copy link
Member

Do they have the correct extensions enabled? All the acceptance containers seem to be failing: https://drone.nextcloud.com/nextcloud/server/5578/64/4

gary-kim
gary-kim requested changes May 28, 2021
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@gary-kim
Copy link
Member

Should be fixed once nextcloud/docker-ci#285 is merged then php7.3 gets rebuilt then acceptance-php7.3 gets rebuilt.

@LukasReschke
Use GHCR PHP 7.3 Acceptance Container
ee2a0f2 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke
Bump Container Versions
3e6e6ee 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke force-pushed the use-ghcr-acceptance branch from 492deb1 to 3e6e6ee Compare May 28, 2021 21:44
@LukasReschke
Copy link
Member Author

Thanks @gary-kim. I've bumped all the versions :)

@LukasReschke LukasReschke requested a review from gary-kim May 28, 2021 21:45
@LukasReschke LukasReschke merged commit 621a4bc into master May 28, 2021
@LukasReschke LukasReschke deleted the use-ghcr-acceptance branch May 28, 2021 21:58
@LukasReschke
Copy link
Member Author

Merging as this mitigates CI issues in master.

@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasReschke @gary-kim @MorrisJobke