Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit Sidebar events on nextcloud-bus #27123

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Emit Sidebar events on nextcloud-bus #27123

merged 1 commit into from
Jun 7, 2021

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 26, 2021 •
edited
Loading

Emit sidebar events on nextcloud's event bus.

The only tweak is for the closed event. As commented:

For the handleClosed event listener, we need to listen to the hook:destroyed event instead of the closed event.
This is necessary because with v-if, the 'closed' event is emitted after the destruction of AppSidebar, and all the event listeners are unbound and won't be triggered.

This assumed that the handleClosed event occurres almost at the same time as the closed event.

@artonge artonge added 2. developing Work in progress enhancement feature: file sidebar Related to the file sidebar component labels May 26, 2021
@artonge artonge added this to the Nextcloud 22 milestone May 26, 2021
@artonge artonge force-pushed the feature/emit_sidebar_events branch 2 times, most recently from a3b0ef0 to fe25634 Compare May 27, 2021 08:16
@artonge
Copy link
Contributor Author

artonge commented May 27, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the feature/emit_sidebar_events branch from fe25634 to 58b9e4b Compare May 27, 2021 10:08
@artonge artonge force-pushed the feature/emit_sidebar_events branch 6 times, most recently from 60f1faf to b6c1a9c Compare May 31, 2021 14:50
@artonge
Copy link
Contributor Author

artonge commented May 31, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the feature/emit_sidebar_events branch from b6c1a9c to 6ed61c2 Compare May 31, 2021 15:09
@artonge artonge changed the title Emit sidebar events Emit sidebar events on Nextcloud's bus May 31, 2021
@artonge artonge changed the title Emit sidebar events on Nextcloud's bus Emit sidebar events on nextcloud-bus May 31, 2021
@artonge artonge changed the title Emit sidebar events on nextcloud-bus Emit Sidebar events on nextcloud-bus May 31, 2021
@artonge artonge force-pushed the feature/emit_sidebar_events branch from 6ed61c2 to d5575a2 Compare May 31, 2021 17:01
@artonge artonge requested a review from skjnldsv May 31, 2021 17:04
@skjnldsv skjnldsv marked this pull request as ready for review May 31, 2021 19:36
@artonge artonge force-pushed the feature/emit_sidebar_events branch 2 times, most recently from 72a11e0 to 92bf189 Compare June 1, 2021 12:44
@skjnldsv
Copy link
Member

skjnldsv commented Jun 1, 2021

Needs @nexxtcloud/vue@3.10.1

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 1, 2021
@artonge artonge force-pushed the feature/emit_sidebar_events branch from 92bf189 to d6d827c Compare June 1, 2021 13:50
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@artonge artonge force-pushed the feature/emit_sidebar_events branch from d6d827c to 0d4ec7b Compare June 2, 2021 15:07
@artonge
Copy link
Contributor Author

artonge commented Jun 2, 2021

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the feature/emit_sidebar_events branch from 0d4ec7b to a544f59 Compare June 2, 2021 15:36
@skjnldsv
Copy link
Member

skjnldsv commented Jun 2, 2021 •
edited
Loading

Node tests fails, please wait for #27265 before rebasing

@blizzz
Copy link
Member

blizzz commented Jun 2, 2021

Node tests fails, please wait for #27265 before rebasing

is merged

@skjnldsv skjnldsv force-pushed the feature/emit_sidebar_events branch 2 times, most recently from 5aad2f6 to b8f6c7b Compare June 2, 2021 19:15
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 2, 2021
@artonge artonge force-pushed the feature/emit_sidebar_events branch from b8f6c7b to 724592d Compare June 3, 2021 08:30
@MorrisJobke
Copy link
Member

Conflicts :/

@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2021

Please rebase @artonge

@artonge artonge force-pushed the feature/emit_sidebar_events branch 2 times, most recently from ede7955 to 8ece719 Compare June 7, 2021 14:35
@artonge
Emit sidebar events
8a66cdb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feature/emit_sidebar_events branch from 8ece719 to 8a66cdb Compare June 7, 2021 14:49
@artonge
Copy link
Contributor Author

artonge commented Jun 7, 2021

All is green !

MorrisJobke
MorrisJobke approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good 👍

@MorrisJobke MorrisJobke merged commit c2ff254 into master Jun 7, 2021
@MorrisJobke MorrisJobke deleted the feature/emit_sidebar_events branch June 7, 2021 21:33
@welcome
Copy link

welcome bot commented Jun 7, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: file sidebar Related to the file sidebar component
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @skjnldsv @blizzz @MorrisJobke