Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Activities for addressbook and contacts #27061

Merged
merged 6 commits into from
May 28, 2021
Merged

⚡ Activities for addressbook and contacts #27061

merged 6 commits into from
May 28, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 21, 2021 •
edited
Loading

  • Create addressbook
  • Update addressbook
  • Delete addressbook
  • (un)Share addressbook
  • Create contact
  • Update contact
  • Delete contact

Fix #3549

Bildschirmfoto von 2021-05-21 15-05-38

@nickvergessen
Add a contacts filter
5fb9256 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add a setting
82629f0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add activities for addressbook management
2496f83 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add activities for creating, updating and deleting contacts
6fff0b8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone May 21, 2021
@nickvergessen
Fix PHP CS
9626138 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/contacts-activity branch from 2e80ec0 to 9626138 Compare May 21, 2021 13:34
@nickvergessen
Remove since from implementations and fix some more style
2a2ca4d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

seems like a few integration tests are failing? or not related?

@skjnldsv
Copy link
Member

Seems unrelated

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2021
@skjnldsv skjnldsv merged commit 17d0dac into master May 28, 2021
@skjnldsv skjnldsv deleted the feature/noid/contacts-activity branch May 28, 2021 15:15
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@ChristophWurst
Copy link
Member

Just wanted to say this is an awesome feature 🚀 Yet again someone added a strange contact to a shared addressbook and I can now finally see who did it :)

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: activity and notification feature: dav
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

Contact changes in activity stream
4 participants
@nickvergessen @szaimen @skjnldsv @ChristophWurst