-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provisioning API to use only public API of IAccountManager #26923
provisioning API to use only public API of IAccountManager #26923
Conversation
a860557
to
1e271e9
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Integration tests are failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing integration test is related
yes, addressing this after the dav stuff in the other PR. |
the auto-fallback to v2-local is removed as well to react on wrong input Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
So the test failed, because the AccountProperty does not accept an invalid value, but falls back to @PVince81 I removed the auto-fallback to v2-local, to react properly on invalid data (and satisfy integration test). Was there a specific reason why it was there in first place? Not that I am breaking something else. |
I don't remember whether the fallback from "invalid value" to "v2-local" was important. |
helps with #26866