-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable11] Fix legacy DAV endpoint #2685
Conversation
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Faldon, @tcitworld and @MorrisJobke to be potential reviewers. |
45cb71d
to
811f167
Compare
Since the tests to quite hugely rely on sync tokens being present I also included those in the legacy backend. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
811f167
to
7d65239
Compare
@rullzer Can you revert your changes to the test file? In my opinion we should 1:1 use the same test file on this branch as in stable10 and if something fails then … well, then we should adjust the endpoint. Not the test file. This seems wrong to me. |
* CaldavBackend is now endpoint aware (use old style principals on old endpoint and new onces on new). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
7d65239
to
b452e25
Compare
@pbek could you try this patch? |
@LukasReschke also you please try again. Hopefully this works... |
@rullzer the last test brought my NC version up to 12.0.0.10, after checking out |
@pbek uhm. If it is a live instance better not. If this works for @LukasReschke I'll create a master PR you should then be able to test. |
@rullzer, no, I just created that instance for testing the CalDAV PRs. |
ah uhm. Well either install again. Or edit the version in |
I went for the latter. |
@rullzer I too can confirm your fix works! Thanks a million! |
Phew. Ok let me wait for a review of @LukasReschke and then this can hopefully soon go in :D |
Failing tests are unrelated (jsunit + timeout) |
LGTM |
This is #2684 for stable11, as the test fail this clearly proofs that something is broken 😢
See https://drone.nextcloud.com/nextcloud/server/3075/32 and https://drone.nextcloud.com/nextcloud/server/3075/35
cc @rullzer