Fix S3 ObjectStore proxy option

[maxbes]

The proxy option in S3 object store does not current work

  'objectstore' => 
  array (
    'class' => '\\OC\\Files\\ObjectStore\\S3',
    'arguments' => 
    array (
    # other_arguments
      'proxy' => 'localhost:3128',
    ),

tries to set an unknown/deprecated "request.options" key when constructing a S3Client. The correct one is "http"

Additionally, S3ObjectTrait::readObject uses fopen() directly, so object store proxy options must also be passed to it

[rullzer]

I can't test but it looks sane

[maxbes]

Sorry for the delay in fixing this, I did not realize the comment on getProxy() was a blocker. Any chance this PR could get in NC22?

[juliusknorr]

Failures unrelated

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[juliusknorr]

/backport to stable22

[orandev]

Hello @juliushaertl
I see no PR for the backport to NC 22 and I don't see the code of the PR in NC 22.1.1, is it normal?

[juliusknorr]

Thanks for the hint, seems the backport bot was not picking that up. Let me retry.

[juliusknorr]

/backport to stable22