Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Testcase class compatible with phpunit-9.5 #26353

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Make Testcase class compatible with phpunit-9.5 #26353

merged 1 commit into from
Mar 29, 2021

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Make Testcase class compatible with phpunit-9.5
cd35a5c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Mar 29, 2021
ChristophWurst
ChristophWurst approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a beauty

@nickvergessen
Copy link
Member Author

To test with 9.5 checkout nextcloud/notifications#901

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 29, 2021
@nickvergessen nickvergessen merged commit 8d3fdf2 into master Mar 29, 2021
@nickvergessen nickvergessen deleted the techdebt/noid/make-testcase-class-compatible-with-phpunit-9.5 branch March 29, 2021 08:47
@kesselb kesselb mentioned this pull request Mar 30, 2021
Merged
@nickvergessen
Copy link
Member Author

/backport to stable21

@nickvergessen nickvergessen mentioned this pull request Apr 22, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @MorrisJobke @ChristophWurst