Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Fix casing of core test folder, bring back missing tests #26275

Merged
merged 9 commits into from
Mar 24, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #26265

It seems Phpunit < 9 was case insensitive.
Fixed the phpunit config to target the correct name for the "Core" test
directory.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Remove "ocs-provider" test folder reference as it doesn't exist any
more.
Added back "Test" test subdir and fixed the tests inside.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Fixes issue with Oracle by enforcing the order of the results to check.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Mar 24, 2021
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

I've reverted some test changes to match stable20 APIs and expectations.

@MorrisJobke
Copy link
Member

I've reverted some test changes to match stable20 APIs and expectations.

There are still some issues.

This reverts commit acfffcc.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

it was just more tests to revert. adjusted now

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2021
@MorrisJobke MorrisJobke merged commit 5f9f997 into stable20 Mar 24, 2021
@MorrisJobke MorrisJobke deleted the backport/26265/stable20 branch March 24, 2021 20:45
@rullzer rullzer mentioned this pull request Mar 26, 2021
2 tasks
This was referenced Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants