Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable21] Only clear share password model when actually saved #26058

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[stable21] Only clear share password model when actually saved #26058

merged 1 commit into from
Mar 11, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 11, 2021 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #25911

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 21.0.1 milestone Mar 11, 2021
@PVince81
Copy link
Member

/compile amend /

@PVince81 @npmbuildbot-nextcloud
Only clear share password model when actually saved
ec44315 
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/25911/stable21 branch from 70af5aa to ec44315 Compare March 11, 2021 10:05
PVince81
PVince81 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 11, 2021
@PVince81 PVince81 merged commit 04dd7b2 into stable21 Mar 11, 2021
@PVince81 PVince81 deleted the backport/25911/stable21 branch March 11, 2021 14:15
@rullzer rullzer mentioned this pull request Mar 26, 2021
Merged
2 tasks
@rullzer rullzer mentioned this pull request Apr 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@danxuliu danxuliu Awaiting requested review from danxuliu

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 21.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @rullzer @skjnldsv