Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provisioning API to IBootstrap #26029

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Provisioning API to IBootstrap #26029

merged 2 commits into from
Mar 10, 2021

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 9, 2021

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Mar 9, 2021
@rullzer rullzer added this to the Nextcloud 22 milestone Mar 9, 2021
@rullzer
Copy link
Member Author

rullzer commented Mar 9, 2021

/backport to stable21

@nickvergessen nickvergessen mentioned this pull request Mar 9, 2021
Merged
8 tasks
@rullzer rullzer force-pushed the enh/boostrap/provisioning_api branch 2 times, most recently from 0f62d58 to e5b1d59 Compare March 10, 2021 08:39
@rullzer
Provisioning API to IBootstrap
e5b1d59 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
PVince81
PVince81 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm guessing this is to remove the annoying warnings in the logs ?
Assuming that the other things marked by code scanning won't spam the logs.

@rullzer
Copy link
Member Author

rullzer commented Mar 10, 2021

+1

I'm guessing this is to remove the annoying warnings in the logs ?
Assuming that the other things marked by code scanning won't spam the logs.

More so Joas can continue with his code :)

@ChristophWurst
Copy link
Member

please address the inline psalm reports. they seem all legit :)

@nickvergessen
Copy link
Member

Just for the record we need to backport to 21, so only "cleanup" what works there.

@nickvergessen
Fix some psalm warnings
a1e5090 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the enh/boostrap/provisioning_api branch from ebcc772 to a1e5090 Compare March 10, 2021 12:02
@kesselb kesselb merged commit 62929cc into master Mar 10, 2021
@kesselb kesselb deleted the enh/boostrap/provisioning_api branch March 10, 2021 13:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 10, 2021
Merged
@nextcloud nextcloud deleted a comment from kesselb Mar 10, 2021
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Mar 10, 2021
@nickvergessen
Copy link
Member

Backport worked in #26044

Not sure what the bot was complaining about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
5 participants
@rullzer @ChristophWurst @nickvergessen @PVince81 @kesselb