Also make other shares listen to the "Allow sharing with groups"

[nickvergessen]

Fixes #25390
Fixes nextcloud/calendar#2744

Todo

• Adjust unit tests
• Create follow up issues in the other apps (contacts, calendar, talk, ....) to remove "groups" from their placeholders

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1812: failure

nodb

Show full log

There were 19 warnings:

1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

6) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

7) OCA\DAV\Tests\unit\DAV\Migration\RefreshWebcalJobRegistrarTest::testRun
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAccept
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptSequence
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptRecurrenceId
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptTokenNotFound
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testAcceptExpiredToken
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testDecline
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

14) OCA\DAV\Tests\Unit\DAV\Controller\InvitationResponseControllerTest::testProcessMoreOptionsResult
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

15) Warning
The data provider specified for ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_8e485e95, its return declaration is ": void"

17) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_493eedff, its return declaration is ": void"

18) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_493eedff, its return declaration is ": void"

19) OCA\user_ldap\tests\Jobs\UpdateGroupsTest::testHandleKnownGroups
Trying to configure method "fetchAll" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 8 failures:

1) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testSearchPrincipals with data set #0 (true, false, 'allof', array('principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5'))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 (
-    0 => 'principals/groups/group1'
-    1 => 'principals/groups/group2'
-    2 => 'principals/groups/group3'
-    3 => 'principals/groups/group4'
-    4 => 'principals/groups/group5'
-)
+Array &0 ()

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:277

2) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testSearchPrincipals with data set #1 (true, false, 'anyof', array('principals/groups/group1', 'principals/groups/group2', 'principals/groups/group3', 'principals/groups/group4', 'principals/groups/group5'))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 (
-    0 => 'principals/groups/group1'
-    1 => 'principals/groups/group2'
-    2 => 'principals/groups/group3'
-    3 => 'principals/groups/group4'
-    4 => 'principals/groups/group5'
-)
+Array &0 ()

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:277

3) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testSearchPrincipals with data set #2 (true, true, 'allof', array('principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5'))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 (
-    0 => 'principals/groups/group1'
-    1 => 'principals/groups/group2'
-    2 => 'principals/groups/group5'
-)
+Array &0 ()

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:277

4) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testSearchPrincipals with data set #3 (true, true, 'anyof', array('principals/groups/group1', 'principals/groups/group2', 'principals/groups/group5'))
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 (
-    0 => 'principals/groups/group1'
-    1 => 'principals/groups/group2'
-    2 => 'principals/groups/group5'
-)
+Array &0 ()

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:277

5) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testFindByUri with data set #4 (true, true, 'principal:principals/groups/group1', 'principals/groups/group1')
Failed asserting that null matches expected 'principals/groups/group1'.

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:323

6) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testFindByUri with data set #5 (true, true, 'principal:principals/groups/group3', null)
Expectation failed for method name is "getUserGroupIds" when invoked at sequence index 0.
The expected invocation at index 0 was never reached.

7) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testFindByUri with data set #6 (true, false, 'principal:principals/groups/group1', 'principals/groups/group1')
Failed asserting that null matches expected 'principals/groups/group1'.

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:323

8) OCA\DAV\Tests\unit\DAV\GroupPrincipalTest::testFindByUri with data set #7 (true, false, 'principal:principals/groups/group3', 'principals/groups/group3')
Failed asserting that null matches expected 'principals/groups/group3'.

/drone/src/apps/dav/tests/unit/DAV/GroupPrincipalTest.php:323

sqlite

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

mariadb10.1-php7.3

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

mariadb10.4-php7.4

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

mysql8.0-php7.4

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

postgres9.6-php7.3

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

postgres11-php7.4

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

postgres12-php7.4

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

postgres13-php7.4

Show full log

There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 7 failures:

1) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #0 (array(), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

2) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #1 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

3) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #2 (array('foobar'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

4) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #3 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

5) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #4 (array(''), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

6) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #6 (array(0), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

7) OCA\Files_Sharing\Tests\Controller\ShareesAPIControllerTest::testSearch with data set #7 (array('call'), '', 'yes', true, true, true, array(0, 1, 4), false, true, true)
OCP\Share\IManager::allowGroupSharing() was not expected to be called.

/drone/src/apps/files_sharing/lib/Controller/ShareesAPIController.php:195
/drone/src/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php:304

acceptance-app-files-sharing-link

• tests/acceptance/features/app-files-sharing-link.feature:158

Show full log

  Scenario: access a direct download shared link protected by password with a valid password                  # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:158
    Given I act as John                                                                                       # ActorContext::iActAs()
    And I am logged in                                                                                        # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt" protected by the password "abcdef"                                 # FilesAppSharingContext::iShareTheLinkForProtectedByThePassword()
      │ The password protect field was not found disabled after 50 seconds, assumming that it was disabled and enabled again before the check started and continuing
    And I write down the shared link                                                                          # FilesAppSharingContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: 'e7066505dee9', ip: '192.168.64.3', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-124-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    When I act as Jane                                                                                        # ActorContext::iActAs()
    And I visit the direct download shared link I wrote down                                                  # PublicShareContext::iVisitTheDirectDownloadSharedLinkIWroteDown()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()
    And I authenticate with password "abcdef"                                                                 # PublicShareContext::iAuthenticateWithPassword()
    And I see that the current page is the Authenticate page for the direct download shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheAuthenticatePageForTheDirectDownloadSharedLinkIWroteDown()

[kesselb]

May fix #20950 (at least visually)