Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle abortion of fetching more data in infiniteHandler #25195

Closed
wants to merge 3 commits into from
Closed

handle abortion of fetching more data in infiniteHandler #25195

wants to merge 3 commits into from

Conversation

chiefbrain
Copy link

See issue #25133.

$state.loaded() needs to be called if users are present.

Introduced in 824b109.

Oliver Wittkopf added 3 commits January 18, 2021 23:18
handle abortion of fetching more data in infiniteHandler
25bea20 
Signed-off-by: Oliver Wittkopf <gitlab@4ward.wittkopf.eu>
add js
fb8a45f 
Signed-off-by: Oliver Wittkopf <gitlab@4ward.wittkopf.eu>
add js 2
547ecc7 
Signed-off-by: Oliver Wittkopf <gitlab@4ward.wittkopf.eu>
skjnldsv
skjnldsv approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement labels Jan 20, 2021
ChristophWurst
ChristophWurst approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@PVince81
Copy link
Member

@eneiluj seems like an early alternative to your fix in #25879

@julien-nc

This comment has been minimized.

Sign in to view
@julien-nc julien-nc mentioned this pull request Jul 2, 2021
Merged
@szaimen szaimen added this to the Nextcloud 23 milestone Jul 2, 2021
@chiefbrain
Copy link
Author

$state.loaded() is called even if filtered users list is empty. So the empty content message won't be displayed when filtering to show disabled users while there is no disabled users. That's why filteredUsers.length is used to determine if we call $state.loaded() in #25879.

length ist still used in users.js: const usersCount = Object.keys(response.data.ocs.data.users).length.

@julien-nc
Copy link
Member

@chiefbrain As I couldn't push to your branch, I applied your changes to my branch in #25879, rebased on master and resolved the conflicts. I hope you don't mind 😁

@ChristophWurst @skjnldsv #25879 is the same as this PR and it's ready to be merged.

@julien-nc julien-nc closed this Jul 27, 2021
@chiefbrain chiefbrain deleted the fix_user_display branch March 2, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.
6 participants
@chiefbrain @PVince81 @julien-nc @ChristophWurst @skjnldsv @szaimen