Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont error the entire repair process when a repair step errors #25112

Merged
merged 3 commits into from
Mar 18, 2021
Merged

dont error the entire repair process when a repair step errors #25112

merged 3 commits into from
Mar 18, 2021

Conversation

icewind1991
Copy link
Member

Instead show the error as any other repair step error

Also includes formatting changes to keep the errors from being drowned out by the rest of the repair output

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 13, 2021
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Jan 13, 2021
This was referenced Jan 14, 2021
Merged
Merged
@rullzer rullzer mentioned this pull request Jan 21, 2021
Merged
19 tasks
@rullzer rullzer mentioned this pull request Jan 29, 2021
Merged
@icewind1991 icewind1991 force-pushed the repair-exception branch 2 times, most recently from d292b95 to 465cadd Compare February 2, 2021 20:08
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Feb 2, 2021
@rullzer
Copy link
Member

rullzer commented Feb 2, 2021

Master is Nextcloud 22 now.
If this should go into 21 it should be backported.

@icewind1991 @MorrisJobke
dont error the entire repair process when a repair step errors
c75b82a 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
make repair errors more visible
9135a42 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
log full expection during repair step
9e37756 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
Copy link
Member

Rebased

MorrisJobke
MorrisJobke approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2021
@kesselb kesselb merged commit dd39f5e into master Mar 18, 2021
@kesselb kesselb deleted the repair-exception branch March 18, 2021 09:14
@ChristophWurst ChristophWurst mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @rullzer @MorrisJobke @kesselb