Actually set the TTL on redis set

[rullzer]

Else well the keys remain for ever and ever.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

[rullzer]

/backport to stable20

[rullzer]

/backport to stable19

[rullzer]

/backport to stable18

[PVince81]

was wondering why we can't use setex as well, found this but not sure: https://www.reddit.com/r/redis/comments/8suupj/expire_option_for_setnx_command/

maybe PHP doesn't have a mapping

[PVince81]

from the docs:

// Will set the key, if it doesn't exist, with a ttl of 10 seconds
$redis->set('key', 'value', ['nx', 'ex'=>10]);

see https://github.com/phpredis/phpredis

[rullzer]

from the docs:

// Will set the key, if it doesn't exist, with a ttl of 10 seconds
$redis->set('key', 'value', ['nx', 'ex'=>10]);

see https://github.com/phpredis/phpredis

aaah that would be fine as well of course

[rullzer]

See the fixup for review

[PVince81]

Code looks fine, not tested 👍

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 615: failure

mysql8.0-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\MoveFromCacheTraitTest::testLongId
null does not match expected type "array".

/drone/src/tests/lib/Files/Cache/CacheTest.php:521