Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-dialog-buttons #24770

Merged
merged 2 commits into from
Dec 22, 2020
Merged

fix-dialog-buttons #24770

merged 2 commits into from
Dec 22, 2020

Conversation

marcoambrosini
Copy link
Member

No clickable things shorter / narrower than 44px :)

Before After
Screenshot from 2020-12-18 15-37-37 Screenshot from 2020-12-18 15-38-56

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@marcoambrosini
fix-dialog-buttons
f2b0afd 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini self-assigned this Dec 18, 2020
@rullzer rullzer added this to the Nextcloud 21 milestone Dec 21, 2020
@rullzer rullzer mentioned this pull request Dec 22, 2020
Merged
39 tasks
jancborchardt
jancborchardt previously requested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The buttons need more left and right padding, so that it doesn't visually look less than the top and bottom padding.

@marcoambrosini
Copy link
Member Author

Screenshot from 2020-12-22 11-33-40

@juliusknorr
Copy link
Member

@ma12-co The bundles need an update:

Uncommited changes in webpack build
HEAD detached at pull/24770/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   core/js/dist/main.js
	modified:   core/js/dist/main.js.map

@rullzer
Copy link
Member

rullzer commented Dec 22, 2020

/compile amend /

@marcoambrosini @npmbuildbot-nextcloud
Increase horizontal padding
23b61de 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@skjnldsv
Copy link
Member

Good to go

@juliusknorr juliusknorr merged commit e28d21a into master Dec 22, 2020
@juliusknorr juliusknorr deleted the fix-dialog-buttons branch December 22, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: accessibility
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoambrosini @juliusknorr @rullzer @skjnldsv @jancborchardt @ChristophWurst