Fix image_src link #2378
Merged
Fix image_src link #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @schiessle and @blizzz to be potential reviewers. |
| @@ -370,7 +370,7 @@ public function showShare($token, $path = '') { | |||
| $shareTmpl['previewMaxY'] = $this->config->getSystemValue('preview_max_y', 1024); | |||
| $shareTmpl['disclaimer'] = $this->config->getAppValue('core', 'shareapi_public_link_disclaimertext', null); | |||
| if ($shareTmpl['previewSupported']) { | |||
| $shareTmpl['previewImage'] = $this->urlGenerator->linkToRouteAbsolute( 'core_ajax_public_preview', | |||
| $shareTmpl['previewImage'] = $this->urlGenerator->linkToRouteAbsolute( 'core.Preview.getPreview', | |||
There was a problem hiding this comment.
this is not @PublicPage ?!
There was a problem hiding this comment.
Stupid hobbit… Yeah… Will fix 🙈
The link in the image_src link (used for previews on Social Media such as Facebook) was still using the old route. This changes it to use the new route. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
c554c88 to
9def822
Compare
|
👍 |
nickvergessen
approved these changes
Nov 28, 2016
|
Tested and works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link in the image_src link (used for previews on Social Media such as Facebook) was still using the old route. This changes it to use the new route.
Signed-off-by: Lukas Reschke lukas@statuscode.ch
Fixes #2364
cc @MorrisJobke @rullzer