-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filepicker styling #2342
Fix filepicker styling #2342
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tanghus, @PVince81 and @jancborchardt to be potential reviewers. |
Really nice. There is only one issue:
|
Potentially also fixes #1864 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Fixed |
Tested and works 👍 |
Chrome, Safari, IE11 and Edge ;) |
LGTM |
Current coverage is 57.03% (diff: 0.00%)@@ master #2342 diff @@
==========================================
Files 1191 1191
Lines 71911 72140 +229
Methods 7299 7335 +36
Messages 0 0
Branches 1213 1226 +13
==========================================
+ Hits 41036 41142 +106
- Misses 30875 30998 +123
Partials 0 0
|
Fixes #2252
Also now limits the filepicker size to fit in small screens.
cc @jancborchardt @LukasReschke