Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Only run the query to get the account data once #23221

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #23215

Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot
Copy link

faily-bot bot commented Oct 6, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33718: failure

mysql8.0-php7.2

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionUploadTest::testChunkedUploadOverWrite
TypeError: Argument 1 passed to OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\ExceptionPlugin::logException() must be an instance of Exception, instance of TypeError given, called in /drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php on line 89

/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/ExceptionPlugin.php:33
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:254
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:133
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:115
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:123

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

acceptance-header

  • tests/acceptance/features/header.feature:31
Show full log
  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:31
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@MorrisJobke MorrisJobke merged commit eba468d into stable19 Oct 6, 2020
@MorrisJobke MorrisJobke deleted the backport/23215/stable19 branch October 6, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants