Check if debugMode is defined before using it #21657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else the sabre error page (where the var is not defined) will throw warnings all the time. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
georgehrke
approved these changes
Jul 2, 2020
|
@rullzer Backport? |
|
/backport to stable19 |
|
/backport to stable18 |
|
yeah lets. it is not a big dael. But also a trivial backport. So all good |
kesselb
approved these changes
Jul 2, 2020
|
The backport to stable18 failed. Please do this backport manually. |
rullzer
added a commit
that referenced
this pull request
Jul 3, 2020
Manual backport of "Check if debugMode is defined before using it" #21657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21150
Else the sabre error page (where the var is not defined) will throw
warnings all the time.
Was reported in sentry.
https://sentry.io/share/issue/bd815c63035749edba6754887b0602c2/