Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Fix autocomplete for LDAP with shareapi_only_share_with_group_members on #21539

Merged
merged 4 commits into from
Jul 1, 2020
Merged

[stable18] Fix autocomplete for LDAP with shareapi_only_share_with_group_members on #21539

merged 4 commits into from
Jul 1, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 23, 2020 •
edited by nickvergessen
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #21452

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.7 milestone Jun 23, 2020
@nickvergessen
Move back to IGroupManager::displayNamesInGroup()
1e3748f 
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add another test for exact matching of a user in group restriction
00ec9e7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix PHP CS
3495f4c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix unit tests
0d86989 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the backport/21452/stable18 branch from faa6df6 to 0d86989 Compare June 23, 2020 12:55
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jun 23, 2020
@nickvergessen
Copy link
Member

Fixed the backport conflict

@nickvergessen nickvergessen merged commit 2d2b413 into stable18 Jul 1, 2020
@nickvergessen nickvergessen deleted the backport/21452/stable18 branch July 1, 2020 08:13
@rullzer rullzer mentioned this pull request Jul 6, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing feature: users and groups
Projects
None yet
Milestone
Nextcloud 18.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @ChristophWurst