Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Pass the proper share permissions to the create share call #21355

Merged
merged 1 commit into from
Jun 11, 2020
Merged

[stable18] Pass the proper share permissions to the create share call #21355

merged 1 commit into from
Jun 11, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 10, 2020 •
edited by rullzer
Loading

⚠️ This backport had conflicts and is incomplete ⚠️
assets rebuild

backport of #21347

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.7 milestone Jun 10, 2020
@rullzer
Copy link
Member

rullzer commented Jun 10, 2020

/compile amend /

@rullzer rullzer added the 3. to review Waiting for reviews label Jun 10, 2020
@rullzer
Pass the proper share permissions to the create share call
9c6d301 
Fixes #21188

This way we do not run into the share permission issue

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the backport/21347/stable18 branch from 23bf7f5 to 9c6d301 Compare June 11, 2020 09:59
danxuliu
danxuliu approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer rullzer merged commit 3c3008a into stable18 Jun 11, 2020
@rullzer rullzer deleted the backport/21347/stable18 branch June 11, 2020 13:16
@rullzer rullzer mentioned this pull request Jul 6, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu danxuliu approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 18.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @danxuliu