Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Enable fseek for files in S3 storage #20966

Merged
merged 5 commits into from
May 25, 2020
Merged

[stable17] Enable fseek for files in S3 storage #20966

merged 5 commits into from
May 25, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 14, 2020 •
edited by MorrisJobke
Loading

backport of #20033

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 17.0.7 milestone May 14, 2020
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews bug labels May 14, 2020
@rullzer rullzer mentioned this pull request May 21, 2020
Merged
3 tasks
@kesselb
Copy link
Contributor

kesselb commented May 21, 2020

I would backport #20385 as well.

ahti and others added 5 commits May 22, 2020 15:31
@ahti @MorrisJobke
Enable fseek for files in S3 storage
4611577 
Signed-off-by: Lukas Stabe <lukas@stabe.de>
@icewind1991 @MorrisJobke
make seekable s3 stream generic
2ecf23a 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
add basic tests for s3 seeking and add some error handling if reopen …
2356088 
…return the wrong range

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
update autoloader
44ea3b8 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
harden seekable http stream a bit against failures
e471c37 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke MorrisJobke force-pushed the backport/20033/stable17 branch from c90a4e3 to e471c37 Compare May 22, 2020 13:31
@MorrisJobke
Copy link
Member

I would backport #20385 as well.

Added here as well.

MorrisJobke
MorrisJobke approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke mentioned this pull request May 22, 2020
Merged
@MorrisJobke
Copy link
Member

I redid the backport manually and the conflict was only due to changed array() to [] syntax. So this is a clean backport.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 22, 2020
@MorrisJobke MorrisJobke mentioned this pull request May 25, 2020
Merged
@MorrisJobke MorrisJobke merged commit 27486cf into stable17 May 25, 2020
@MorrisJobke MorrisJobke deleted the backport/20033/stable17 branch May 25, 2020 11:47
@MorrisJobke MorrisJobke mentioned this pull request May 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@kesselb kesselb Awaiting requested review from kesselb

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 17.0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @MorrisJobke @rullzer @ahti @icewind1991