Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Use random_bytes #20924

Merged
merged 1 commit into from
May 11, 2020
Merged

[stable18] Use random_bytes #20924

merged 1 commit into from
May 11, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 11, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #20915

@rullzer @backportbot
Use random_bytes
b02a79b 
Since we don't care if it is human readbale.
The code is backwards compatible with the old format.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.5 milestone May 11, 2020
georgehrke
georgehrke approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete backport only related to whitespace changes, not code related 👍

@rullzer rullzer added the 4. to release Ready to be released and/or waiting for tests to finish label May 11, 2020
@rullzer rullzer merged commit 30a7c4f into stable18 May 11, 2020
@rullzer rullzer deleted the backport/20915/stable18 branch May 11, 2020 19:00
@rullzer rullzer mentioned this pull request May 21, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 18.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@georgehrke @ChristophWurst @rullzer