Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getDirectoryContent implementation for Jail wrapper #20725

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fix getDirectoryContent implementation for Jail wrapper #20725

merged 1 commit into from
Apr 30, 2020

Conversation

icewind1991
Copy link
Member

🙈

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 29, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Apr 29, 2020
nickvergessen
nickvergessen approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Apr 30, 2020

CI says no

@rullzer rullzer mentioned this pull request Apr 30, 2020
Merged
11 tasks
@icewind1991 icewind1991 force-pushed the getDirectoryContent-fix-jail branch from 5029d86 to 3929678 Compare April 30, 2020 12:17
@icewind1991
Fix getDirectoryContent implementation for Jail wrapper
4e6d3d1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the getDirectoryContent-fix-jail branch from 3929678 to 4e6d3d1 Compare April 30, 2020 13:27
@icewind1991
Copy link
Member Author

CI says no

Fixed

@rullzer rullzer mentioned this pull request Apr 30, 2020
Merged
2 tasks
@rullzer rullzer merged commit 1a04033 into master Apr 30, 2020
@rullzer rullzer deleted the getDirectoryContent-fix-jail branch April 30, 2020 18:34
@rullzer
Copy link
Member

rullzer commented May 1, 2020

backports?

@MorrisJobke
Copy link
Member

/backport to stable18

@MorrisJobke
Copy link
Member

/backport to stable17

@MorrisJobke
Copy link
Member

/backport to stable16

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 25, 2020
Closed
This was referenced May 25, 2020
Closed
Closed
@icewind1991
Copy link
Member Author

I don't think this needs backports, the api it fixes only exists in 19 iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @rullzer @MorrisJobke @nickvergessen @skjnldsv