Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a wrapper to fall back to the share owner on public shares #20718

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add a wrapper to fall back to the share owner on public shares #20718

merged 1 commit into from
Apr 30, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 29, 2020

Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

It is basicallyt a fall back since the public webdav endpoint is so unauthenticated.

  1. create a local external storage
  2. share it with edit rights
  3. open link
  4. Upload a file
  5. delte a file

before: boom
after: no boom

@rullzer rullzer added bug 3. to review Waiting for reviews labels Apr 29, 2020
@rullzer rullzer added this to the Nextcloud 19 milestone Apr 29, 2020
@rullzer rullzer mentioned this pull request Apr 29, 2020
Merged
11 tasks
@rullzer
Add a wrapper to fall back to the share owner on public shares
bc66bdc 
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the fix/public_share_owner_activity_mess branch from a6fbcf6 to bc66bdc Compare April 30, 2020 06:57
ChristophWurst
ChristophWurst approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

MorrisJobke
MorrisJobke approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 0f9b88c into master Apr 30, 2020
@MorrisJobke MorrisJobke deleted the fix/public_share_owner_activity_mess branch April 30, 2020 11:46
@MorrisJobke
Copy link
Member

@rullzer Backport?

@rullzer
Copy link
Member Author

rullzer commented Apr 30, 2020

/backport to stable18

@rullzer
Copy link
Member Author

rullzer commented Apr 30, 2020

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 30, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 30, 2020
Merged
@rullzer rullzer mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@georgehrke georgehrke Awaiting requested review from georgehrke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @ChristophWurst