Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate OC router helpers that are provided by packages #19455

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Deprecate OC router helpers that are provided by packages #19455

merged 1 commit into from
Feb 13, 2020

Conversation

ChristophWurst
Copy link
Member

No description provided.

@ChristophWurst ChristophWurst added this to the Nextcloud 19 milestone Feb 13, 2020
@ChristophWurst ChristophWurst self-assigned this Feb 13, 2020
@ChristophWurst
Copy link
Member Author

This also fixes https://github.com/orgs/nextcloud/projects/31#card-21153825

rullzer
rullzer approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeehaaa!

@rullzer
Copy link
Member

rullzer commented Feb 13, 2020

jsunit says no

@ChristophWurst
Deprecate OC router helpers that are provided by packages
d4e68dd 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the techdebt/deprecate-oc-router-helpers branch from bcda96c to d4e68dd Compare February 13, 2020 15:42
@ChristophWurst
Copy link
Member Author

jsunit says no

Whoopsie broke something while cleaning up the code before the push. Fixed.

@ChristophWurst ChristophWurst added pending documentation This pull request needs an associated documentation update 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 13, 2020
@rullzer rullzer merged commit 584e729 into master Feb 13, 2020
@rullzer rullzer deleted the techdebt/deprecate-oc-router-helpers branch February 13, 2020 19:30
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Apr 10, 2020
ChristophWurst added a commit to nextcloud/documentation that referenced this pull request Apr 10, 2020
@ChristophWurst
Update deprecated globals in 19
6df2b50 
Ref nextcloud/server#19455
Ref nextcloud/server#19346
Ref nextcloud/server#15403

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@tcitworld tcitworld Awaiting requested review from tcitworld

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @juliusknorr