Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefreshWebcalJob: replace ugly Regex with standard php utils #16199

Merged
merged 1 commit into from
Jul 2, 2019
Merged

RefreshWebcalJob: replace ugly Regex with standard php utils #16199

merged 1 commit into from
Jul 2, 2019

Conversation

georgehrke
Copy link
Member

No description provided.

@georgehrke georgehrke added the 3. to review Waiting for reviews label Jul 2, 2019
@georgehrke
Copy link
Member Author

georgehrke commented Jul 2, 2019 •
edited by rullzer
Loading

/backport to stable16

@georgehrke
Copy link
Member Author

georgehrke commented Jul 2, 2019 •
edited by rullzer
Loading

/backport to stable15

rullzer
rullzer approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
I like the filter_var approach

@rullzer rullzer requested a review from MorrisJobke July 2, 2019 17:45
@rullzer rullzer added this to the Nextcloud 17 milestone Jul 2, 2019
@georgehrke
RefreshWebcalJob: replace ugly Regex with standard php utils
089a421 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/refresh_webcal_job_enhancements branch from 7859ad6 to 089a421 Compare July 2, 2019 18:05
MorrisJobke
MorrisJobke approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 2, 2019
@MorrisJobke MorrisJobke merged commit c32f14e into master Jul 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/refresh_webcal_job_enhancements branch July 2, 2019 21:02
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 2, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #16201

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 2, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #16202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
3 participants
@georgehrke @rullzer @MorrisJobke