Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalidates user when plugin reported deletion success #16101

Merged
merged 2 commits into from
Jun 27, 2019
Merged

invalidates user when plugin reported deletion success #16101

merged 2 commits into from
Jun 27, 2019

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 26, 2019

so the internal state reflects that the user is not existing anymore, also the user id getting freed.

Found when working on nextcloud/ldap_write_support#1

@blizzz
invalidates user when plugin reported deletion success
108227c 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 17 milestone Jun 26, 2019
@blizzz
Copy link
Member Author

blizzz commented Jun 26, 2019

/backport to stable16

@blizzz blizzz mentioned this pull request Jun 26, 2019
Merged
4 tasks
@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 26, 2019
@blizzz
Copy link
Member Author

blizzz commented Jun 26, 2019 •
edited
Loading

i might need to extend it for group stuff, too done

@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 27, 2019
@blizzz
Also invalidate groups after deletion
d0f31c5 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented Jun 27, 2019

failing guestAvatarTest is unrelated

georgehrke
georgehrke approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good stuff, keep it coming ❤

@blizzz blizzz merged commit 690406d into master Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/ldap/invaliate-user-after-delete-by-plugin branch June 27, 2019 10:21
@blizzz
Copy link
Member Author

blizzz commented Jun 27, 2019

/backport to stable15

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 27, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #16112

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 27, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #16113

@blizzz blizzz mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@viniciuscb viniciuscb Awaiting requested review from viniciuscb

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @georgehrke @skjnldsv