-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the icon-class with an absolute link to an image #14664
Merged
rullzer
merged 8 commits into
master
from
bugfix/noid/absolute-paths-of-images-for-linked-collaboration-resources
Mar 19, 2019
Merged
Replace the icon-class with an absolute link to an image #14664
rullzer
merged 8 commits into
master
from
bugfix/noid/absolute-paths-of-images-for-linked-collaboration-resources
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
rullzer
approved these changes
Mar 13, 2019
nickvergessen
commented
Mar 14, 2019
266f5b6
to
5898621
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 17121: failureTESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link
Show full log
|
Otherwise the icon can not be displayed in mobile apps Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Joas Schilling <coding@schilljs.com>
cd1aa59
to
21425eb
Compare
juliusknorr
approved these changes
Mar 19, 2019
rullzer
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the icon can not be displayed in mobile apps
ToDo: