Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make assemblystream seekable #14641

Merged
merged 1 commit into from
Mar 15, 2019
Merged

make assemblystream seekable #14641

merged 1 commit into from
Mar 15, 2019

Conversation

icewind1991
Copy link
Member

Fixes #14618

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 12, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 12, 2019
@icewind1991
make assemblystream seekable
6a47f92 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the assemblystream-seek branch from 693754f to 6a47f92 Compare March 13, 2019 15:32
rullzer
rullzer approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
I would welcome more tests

@faily-bot
Copy link

faily-bot bot commented Mar 15, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17055: failure

TESTS=ui-regression

MorrisJobke
MorrisJobke approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@MorrisJobke MorrisJobke merged commit 8ff536f into master Mar 15, 2019
@MorrisJobke MorrisJobke deleted the assemblystream-seek branch March 15, 2019 11:25
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @MorrisJobke